Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Android command line tools #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ JSON file scheme:
```

Parameters:
<br>For official help refer to `avdmanager` binary file: `<sdk_root>/tools/bin/avdmanager create avd`
<br>For official help refer to `avdmanager` binary file: `<sdk_root>/cmdline-tools/latest/bin/avdmanager create avd`
- `avd_name` - name of your AVD, avoid using spaces, this field is necessary
- `create_avd_package` - path to system image in example "system-images;android-23;google_apis;x86_64"
- `create_avd_device` - name of your device visible on `avdmanager list device` list
Expand Down
2 changes: 1 addition & 1 deletion lib/fastlane/plugin/automated_test_emulator_run.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module Fastlane
module AutomatedTestEmulatorRun
def self.all_classes
Dir[File.expand_path('**/{actions,factory,provider}/*.rb', File.dirname(__FILE__))]
Dir[File.expand_path('**/{actions,factory,provider,helper}/*.rb', File.dirname(__FILE__))]
end
end
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,8 @@ def self.available_options
optional: false),
FastlaneCore::ConfigItem.new(key: :SDK_path,
env_name: "SDK_PATH",
description: "The path to your android sdk directory (root). ANDROID_HOME by default",
default_value: ENV['ANDROID_HOME'],
description: "The path to your android sdk directory (root). ANDROID_SDK_ROOT by default",
default_value: ENV['ANDROID_SDK_ROOT'] || ENV['ANDROID_HOME'],
is_string: true,
optional: true),

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ def self.get_adb_controller(params)
UI.message(["Preparing commands for Android ADB"].join(" ").yellow)

# Get paths
path_sdk = "#{params[:SDK_path]}"
path_avdmanager_binary = path_sdk + "/tools/bin/avdmanager"
path_adb = path_sdk + "/platform-tools/adb"
sdk_helper = Helper::SdkHelper.new(params)
path_avdmanager_binary = sdk_helper.avd_manager
path_adb = sdk_helper.adb

# ADB shell command parts
sh_stop_adb = "kill-server"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ def self.get_avd_controller(params, avd_scheme)
UI.message(["Preparing parameters and commands for emulator:", avd_scheme.avd_name].join(" ").yellow)

# Get paths
path_sdk = "#{params[:SDK_path]}"
path_avdmanager_binary = path_sdk + "/tools/bin/avdmanager"
path_adb = path_sdk + "/platform-tools/adb"
sdk_helper = Helper::SdkHelper.new(params)
path_avdmanager_binary = sdk_helper.avd_manager
path_adb = sdk_helper.adb
path_avd = "#{params[:AVD_path]}"

# Create AVD shell command parts
Expand Down Expand Up @@ -51,7 +51,7 @@ def self.get_avd_controller(params, avd_scheme)
sh_create_config_loc = "#{path_avd}/#{avd_scheme.avd_name}.avd/config.ini"

# Launch AVD shell command parts
sh_launch_emulator_binary = [path_sdk, "/emulator/", avd_scheme.launch_avd_launch_binary_name].join("")
sh_launch_emulator_binary = [sdk_helper.emulator_dir, avd_scheme.launch_avd_launch_binary_name].join("")
sh_launch_avd_name = ["-avd ", avd_scheme.avd_name].join("")
sh_launch_avd_additional_options = avd_scheme.launch_avd_additional_options
sh_launch_avd_port = ["-port", avd_scheme.launch_avd_port].join(" ")
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
module Fastlane
module Helper
class SdkHelper
def initialize(params)
@sdk_root_path = params[:SDK_path]
end

def command_line_tools_dir
return "#{@sdk_root_path}/cmdline-tools/latest/bin" if File.exist?("#{@sdk_root_path}/cmdline-tools/latest/bin")

return tools_dir # Fallback on old tools path
end

def tools_dir
return "#{@sdk_root_path}/tools/bin"
end

def platform_tools_dir
return "#{@sdk_root_path}/platform-tools"
end

def emulator_dir
return "#{@sdk_root_path}/emulator/"
end

def adb
return "#{platform_tools_dir}/adb"
end

def avd_manager
return "#{command_line_tools_dir}/avdmanager"
end
end
end
end