This repository was archived by the owner on May 18, 2023. It is now read-only.
Changed verify visibility from external to public#23
Open
Turupawn wants to merge 1 commit intoAztecProtocol:masterfrom
Open
Changed verify visibility from external to public#23Turupawn wants to merge 1 commit intoAztecProtocol:masterfrom
Turupawn wants to merge 1 commit intoAztecProtocol:masterfrom
Conversation
Member
|
As the verifier uses hardcoded memory accesses ( and does not continue from the free memory pointer ), we do not want to enable contracts to inherit from the Verifier contacts, but for them to make an external library calls to them. This avoids situations where the verifier overwrites memory within the parent contract. I'll make a note on the linked issue about how is best to call them |
Author
|
Oh I see, makes sense. Thanks for note! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made this change only on
BaseStandardVerifier.solandBaseUltraVerifier.solsolidity files. TheIVerifier.solinterfaces should continueexternalas is expected from interfaces.