Skip to content
This repository was archived by the owner on May 18, 2023. It is now read-only.

Changed verify visibility from external to public#23

Open
Turupawn wants to merge 1 commit intoAztecProtocol:masterfrom
Turupawn:master
Open

Changed verify visibility from external to public#23
Turupawn wants to merge 1 commit intoAztecProtocol:masterfrom
Turupawn:master

Conversation

@Turupawn
Copy link

Made this change only on BaseStandardVerifier.sol and BaseUltraVerifier.sol solidity files. The IVerifier.sol interfaces should continue external as is expected from interfaces.

@Maddiaa0
Copy link
Member

Maddiaa0 commented May 11, 2023

As the verifier uses hardcoded memory accesses ( and does not continue from the free memory pointer ), we do not want to enable contracts to inherit from the Verifier contacts, but for them to make an external library calls to them. This avoids situations where the verifier overwrites memory within the parent contract.

I'll make a note on the linked issue about how is best to call them

@Turupawn
Copy link
Author

Oh I see, makes sense. Thanks for note!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants