Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing errors (location, legend, uri) #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yodobrin
Copy link

@yodobrin yodobrin commented Feb 9, 2022

Purpose

Few errors on the sample provided:

  1. location of the input json files, as of now they are all under /SDK Sample/ and not under the API, therefore the notebook will not run.
  2. the endpoint / endpoint_latest is used twice, in one location there is no need for the prefix 'https' and in another there is, i added a quick fix for this
  3. there are 3 compatibility warning, which i corrected using 'legend_label' instead of 'label'
  4. the result coming back from REST call, return attributes without the 's' like UpperMargin (not UpperMargins)

Does this introduce a breaking change?

[ ] Yes
[ x] No


## Pull Request Type
What kind of change does this Pull Request introduce?


[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code

  • Test the code
    clone the repo
    add apikey and endpoint in the notebooks.
    run each cell - no errors

What to Check

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant