Add Load Balancing Sample #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonkurtz-MSFT
added
documentation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new load balancing sample including APIM policies, backend pool modules, and an accompanying notebook to demonstrate various load balancing configurations.
- Fixes a typo in a comment (constitute).
- Introduces a sleepMs parameter in multi-request functions for custom sleep intervals.
- Updates Bicep modules and templates to support the load balancing sample and refactors module parameter handling.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/python/apimtypes.py | Corrects a spelling mistake in a comment |
| shared/python/apimrequests.py | Removes raise_for_status() in _request and adds sleepMs parameter |
| shared/bicep/modules/* | Updates descriptions, removes defaults, and adjusts parameters |
| samples/load-balancing/* | Introduces the load balancing sample and supporting policy XML files |
| samples/_TEMPLATE/, infrastructure/ | Refactors resources and updated policy file loading methods |
| README.md | Adds a sample list table and improves sample descriptions |
Comments suppressed due to low confidence (5)
shared/python/apimrequests.py:78
- The removal of 'response.raise_for_status()' in _request may hide HTTP errors that could help with debugging. If this omission is intentional, please add a clarifying comment to explain the decision.
response.raise_for_status()
samples/load-balancing/main.bicep:97
- The module name 'aca-webapi29-priority-pool-1' is inconsistent with the related backend module names (which use 'aca-webapi429-1'). Consider renaming it to 'aca-webapi429-priority-pool-1' for clarity and consistency.
name: 'aca-webapi29-priority-pool-1'
samples/load-balancing/main.bicep:121
- The module name 'aca-webapi29-priority-pool-2' seems inconsistent with the backend module naming convention. It may be clearer to change it to 'aca-webapi429-priority-pool-2'.
name: 'aca-webapi29-priority-pool-2'
samples/load-balancing/main.bicep:145
- Consider renaming 'aca-webapi29-priority-pool-3' to 'aca-webapi429-priority-pool-3' to align with the naming used in the backend modules.
name: 'aca-webapi29-priority-pool-3'
samples/load-balancing/main.bicep:169
- The module name 'aca-webapi29-priority-pool-4' appears inconsistent with other related module names. Renaming it to 'aca-webapi429-priority-pool-4' could improve clarity.
name: 'aca-webapi29-priority-pool-4'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the load balancing sample with various prioritized and weighted examples.