Allow for EML and MSG parsing / also check+replace if fileName has "#" character #2868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelafox
reviewed
Jan 7, 2026
| $argumentList | ||
|
|
||
| Start-Process -FilePath $venvPythonPath -ArgumentList $argumentList -Wait -NoNewWindow | ||
| $process = Start-Process -FilePath $venvPythonPath -ArgumentList $argumentList -Wait -NoNewWindow -PassThru |
Collaborator
There was a problem hiding this comment.
Are these changes orthogonal to the EML change?
pamelafox
reviewed
Jan 7, 2026
| files = self.list_file_strategy.list() | ||
| async for file in files: | ||
| try: | ||
| # Check if filename contains # and rename on disk if it does |
Collaborator
There was a problem hiding this comment.
We are going to deprecate integratedvectorizerstrategy.py in favor of cloud ingestion strategy only, so no changes should be needed to this file.
pamelafox
reviewed
Jan 7, 2026
| import email | ||
| from email import policy | ||
| from typing import AsyncGenerator, IO, Union, Optional | ||
| import extract_msg |
Collaborator
There was a problem hiding this comment.
Please run pre-commit on all files to fix formatting, see CONTRIBUTING.md for instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We had a requirement to ingest EMAIL files, EML and MSG. This required a new 'parser' - as well as a new component to display the email, when selected.
Another issue was the "#" character in some fileNames - they would ingest OK, but couldn't use the HREF due to the # within the fileName/Url - rather than DOC.PDF#page1
This PR includes an additional package for the 'extract-msg' - and some CSS tweaks also (for showing MAIL)
Does this introduce a breaking change?
Have been able to deploy via "AZD DEPLOY" and the processing of EML/MSG files is working - and can view them after a chat or ask response. ✅
[ X ] Yes
[ ] No
Type of change
[ X ] Bugfix - with fileName containing "#"
[ X ] Feature - able to ingest EML and MSG
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe: