Skip to content

Skip role assignments for free Azure Search SKU (#2848) #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pamelafox merged 6 commits into from
Jan 9, 2026
Merged

Skip role assignments for free Azure Search SKU (#2848) #2886

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7dcdd4
Fix: skip role assignments when principalId is empty to avoid Invalid…
nb-a153 Dec 31, 2025
d4503fb
Add checks to each role in main.bicep that is assigned to searchServi…
nb-a153 Jan 7, 2026
d27bd24
Add checks to each role in main.bicep that is assigned to searchServi…
nb-a153 Jan 7, 2026
7403e7b
Add limitations in docs
nb-a153 Jan 7, 2026
5757f0a
Revert unneeded change to role.bicep
pamelafox Jan 9, 2026
1235ff0
Merge branch 'main' into fix/skip-role-assignments-free-search
pamelafox Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/core/security/role.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ param principalId string
param principalType string = 'ServicePrincipal'
param roleDefinitionId string

resource role 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
resource role 'Microsoft.Authorization/roleAssignments@2022-04-01' = if (!empty(principalId)) {
name: guid(subscription().id, resourceGroup().id, principalId, roleDefinitionId)
properties: {
principalId: principalId
Expand Down
Loading