Skip to content

Conversation

@Isychan1
Copy link

@Isychan1 Isychan1 commented Jan 8, 2026

Purpose

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[ ] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[ ] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

Copilot AI review requested due to automatic review settings January 8, 2026 21:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new GitHub Actions workflow for testing the Python package using Conda. However, the workflow has several issues that prevent it from functioning properly and make it inconsistent with the project's existing testing infrastructure.

Key observations:

  • Introduces a Conda-based CI workflow that references a non-existent environment.yml file
  • Uses different tooling (flake8) than the existing workflow (ruff)
  • Uses outdated GitHub Actions versions compared to existing workflows

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

echo $CONDA/bin >> $GITHUB_PATH
- name: Install dependencies
run: |
conda env update --file environment.yml --name base
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow references an environment.yml file that does not exist in the repository. The workflow will fail when trying to execute this step. Either create an environment.yml file with the necessary conda dependencies, or use the existing requirements-dev.txt file with pip instead.

Suggested change
conda env update --file environment.yml --name base
python -m pip install --upgrade pip
pip install -r requirements-dev.txt

Copilot uses AI. Check for mistakes.
Comment on lines +24 to +30
- name: Lint with flake8
run: |
conda install flake8
# stop the build if there are Python syntax errors or undefined names
flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow uses flake8 for linting, but the project uses ruff as its linter (as seen in .pre-commit-config.yaml and .github/workflows/python-test.yaml). This creates inconsistency in code quality checks. Consider using ruff instead to match the existing project standards.

Suggested change
- name: Lint with flake8
run: |
conda install flake8
# stop the build if there are Python syntax errors or undefined names
flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
- name: Lint with ruff
run: |
conda install -c conda-forge ruff
# stop the build if there are Python syntax errors or undefined names
ruff check .
# run ruff again but do not fail the build, treating all issues as warnings
ruff check . || true

Copilot uses AI. Check for mistakes.
steps:
- uses: actions/checkout@v4
- name: Set up Python 3.10
uses: actions/setup-python@v3
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions/setup-python action is using version v3, which is outdated. The existing python-test.yaml workflow uses actions/setup-uv@v7 with uv for faster dependency management. Consider updating to use a similar approach or at least upgrade to the latest version of setup-python for better performance and security patches.

Suggested change
uses: actions/setup-python@v3
uses: actions/setup-python@v5

Copilot uses AI. Check for mistakes.
max-parallel: 5

steps:
- uses: actions/checkout@v4
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions/checkout action is using version v4, while the existing python-test.yaml workflow uses v6. Consider updating to v6 for the latest features and security improvements.

Suggested change
- uses: actions/checkout@v4
- uses: actions/checkout@v6

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,34 @@
name: Python Package using Conda

on: [push]
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow triggers on every push to any branch. The existing python-test.yaml workflow has more refined triggers with paths-ignore filters to avoid running on documentation-only changes. Consider adding similar filters to avoid unnecessary CI runs and reduce resource usage.

Suggested change
on: [push]
on:
push:
paths-ignore:
- 'docs/**'
- '**/*.md'

Copilot uses AI. Check for mistakes.
@pamelafox
Copy link
Collaborator

Since this PR has no description, I will assume its an accidentally public PR (intended for your private fork) and close the PR.

@pamelafox pamelafox closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants