Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing developer settings sends the correct overrides #154

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

shibbas
Copy link
Contributor

@shibbas shibbas commented Nov 30, 2023

Purpose

It looks like the overrides being done by developer settings were not being passed into the search call. This PR fixes that.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
Use developer settings and check if the value is being set correctly when sent to the search.

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

@sinedied sinedied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sinedied sinedied merged commit e6b27f6 into develop Dec 4, 2023
6 checks passed
@sinedied sinedied deleted the fix/developer-settings branch December 4, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants