Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update openai api version #197

Merged
merged 1 commit into from
Apr 4, 2024
Merged

chore: update openai api version #197

merged 1 commit into from
Apr 4, 2024

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Apr 3, 2024

Purpose

Old API version will be deprecated starting July, 1st.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

manekinekko
manekinekko approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@manekinekko manekinekko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if:

  • swagger specs didn't changed!
  • we are sure 2024-02-01 didn't introduce any deprecations!

@sinedied
Copy link
Contributor Author

sinedied commented Apr 4, 2024

Yeah nothing changed from our standpoint. We'll have to switch the SDK so that we don't have to care about the version in the future, this will be for another PR

@sinedied sinedied merged commit 8fe7be6 into main Apr 4, 2024
6 checks passed
@sinedied sinedied deleted the api-version branch April 4, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekinekko manekinekko manekinekko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinedied @manekinekko