feat(api): implement /chat and /ask apis in Node.js (#5) #23
Conversation
sinedied
changed the title
| import { MessageBuilder } from '../message-builder.js'; | ||
| import { AskApproach } from './approach.js'; | ||
| import { messagesToString } from '../message.js'; | ||
|
|
There was a problem hiding this comment.
For readability and maintenance, I would move this to a global variables file and outside.
There was a problem hiding this comment.
I'm not sure that would be a good idea, as these prompt are specific to this particular approach. Other approaches have their own set of prompts, and mixing them altogether in a different file would make it more confusing IMO
| const top = overrides?.top ? Number(overrides?.top) : 3; | ||
| const excludeCategory: string | undefined = overrides?.exclude_category; | ||
| const filter = excludeCategory ? `category ne '${excludeCategory.replace("'", "''")}'` : undefined; | ||
|
|
There was a problem hiding this comment.
Will we be using this when integrating a vector database? Otherwise maybe let's delete unnecessary code to make it easier to distro.
There was a problem hiding this comment.
We already use a vector DB, it's Cognitive Search. The code is commented because of the missing SDK features, otherwise it would be used. This is currently a big issue as without using the semantic search and vector search, the results are pretty crap :/
| If the question is not in English, translate the question to English before generating the search query. | ||
| If you cannot generate a search query, return just the number 0. | ||
| `; | ||
|
|
There was a problem hiding this comment.
Again, I would move all this to a global file.
| chatClient = new OpenAI({ | ||
| ...commonOptions, | ||
| baseURL: `${openAiUrl}/openai/deployments/${config.azureOpenAiChatGptDeployment}`, | ||
| }); |
There was a problem hiding this comment.
Are this API endpoints stable?
There was a problem hiding this comment.
Yes, they're used in the AOAI SDK too.
This service will probably be replaced by the AOAI SDK anyways (#22)
sinedied
changed the title
Test it locally
.envfile from azd inpackages/apinpm install && npm startat the root of the projectImplemented
/chatAPI, but with limitations (see [sdk] missing options from JS document-search SDK #21)Missing (for later PRs)
/askAPI (and approaches)