Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AZURE_SEARCH_TOP_K and AZURE_OPENAI_SYSTEM_MESSAGE keeps reseting after running azd env set and azd up command #1146

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Prasanjeet-Microsoft
Copy link
Contributor

@Prasanjeet-Microsoft Prasanjeet-Microsoft commented Jul 17, 2024

Purpose

Added azureOpenAISystemMessage and azureSearchTopK param in main.bicepparam file to set the value of AZURE_SEARCH_TOP_K and AZURE_OPENAI_SYSTEM_MESSAGE env variable in azure using azd env set and azd up command

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Run below commands from VS code powershell terminal:

azd env set AZURE_SEARCH_TOP_K 15
azd up
azd env refresh

And check whether value of AZURE_SEARCH_TOP_K is getting updated in azure and local both. And the value should not get reset to 5 in .env file in your local.

Please find below screenshot for your reference:

image

Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL264558377% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
298 0 💤 0 ❌ 0 🔥 38.871s ⏱️

@Prasanjeet-Microsoft Prasanjeet-Microsoft requested review from adamdougal and Roopan-Microsoft and removed request for adamdougal July 17, 2024 12:22
@adamdougal adamdougal added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 6210255 Jul 17, 2024
10 checks passed
@adamdougal adamdougal deleted the PSL-BUG-5360 branch July 17, 2024 12:50
Copy link

🎉 This PR is included in version 1.9.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants