Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integrated Vectorization] Changes for Admin Configuration page #798

Merged
merged 83 commits into from
May 7, 2024

Conversation

komalg1
Copy link
Collaborator

@komalg1 komalg1 commented May 1, 2024

Purpose

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
If 'AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION' is true, user should be able to see two input values for Max page length & overlap length
image

What to Check

Verify that the following are valid

  • Any updates to the config values should be saved.

ross-p-smith
ross-p-smith previously approved these changes May 3, 2024
Copy link
Collaborator

@ross-p-smith ross-p-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you fixing all my comments!

cecheta
cecheta previously approved these changes May 3, 2024
Copy link
Collaborator

@cecheta cecheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@komalg1 komalg1 dismissed stale reviews from cecheta and ross-p-smith via 6493317 May 6, 2024 19:29
ross-p-smith
ross-p-smith previously approved these changes May 7, 2024
code/backend/Admin.py Outdated Show resolved Hide resolved
gaurarpit
gaurarpit previously approved these changes May 7, 2024
Copy link
Contributor

@gaurarpit gaurarpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@komalg1 komalg1 dismissed stale reviews from gaurarpit and ross-p-smith via ac0f10b May 7, 2024 12:48
code/backend/Admin.py Outdated Show resolved Hide resolved
code/backend/Admin.py Outdated Show resolved Hide resolved
@komalg1 komalg1 requested a review from cecheta May 7, 2024 14:24
Copy link
Collaborator

@cecheta cecheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@komalg1 komalg1 added this pull request to the merge queue May 7, 2024
Merged via the queue into Azure-Samples:main with commit ba0f096 May 7, 2024
5 checks passed
@komalg1 komalg1 deleted the komal/iv-adminconfig branch May 7, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants