Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure com service fix #59

Closed

Conversation

pandeys1004
Copy link

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@lookinnovative
Copy link

lookinnovative commented Oct 31, 2022 via email

Copy link

@lookinnovative lookinnovative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good Approved!

Copy link

@lookinnovative lookinnovative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@petrsvihlik
Copy link

Hello @pandeys1004 ,
thanks for the PR but it's not clear what is its intention. It contains a lot of customer-specific configuration and secrets (such as tokens). There are also samples that duplicate the existing samples (email, etc.)

Moreover, it seems like a duplicate of #57

Could you please first open up an issue in the repo where we can discuss the problem and the right approach? Once we agree on the next steps, you can open up a new PR.

@ddematheu2 can you close this for now?

@pandeys1004 pandeys1004 closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants