Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from template analyser to psrule for security audits #133

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

tonybaloney
Copy link
Contributor

This replaces the MSDO/template analyser tool with PSRule and adds a specific main.test.bicep file with the specific configuration we want to validate.

Overall, it reduces false positives but means if we add features like private networking as optional you can test that specific profile.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@tonybaloney
Copy link
Contributor Author

Reduces the number of issues from 38 to 22. Will address those 22 in separate PRs once this is merged.

@cassiebreviu cassiebreviu merged commit 431b709 into main Jun 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants