-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up AZD folder and update core templates #143
base: main
Are you sure you want to change the base?
Conversation
Those files were probably changed, will investigate |
This could be consolidated with the role assignments parameter above https://github.com/Azure-Samples/contoso-chat/blame/main/infra/core/database/cosmos/sql/cosmos-sql-db.bicep#L70-L82 have amended the bicep |
@@ -90,8 +90,9 @@ module ai 'core/host/ai-environment.bicep' = { | |||
? storageAccountName | |||
: '${abbrs.storageStorageAccounts}${resourceToken}' | |||
openAiName: !empty(openAiName) ? openAiName : 'aoai-${resourceToken}' | |||
openAiConnectionName: 'aoai-connection-${resourceToken}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nitya please can you review |
@tonybaloney - missed seeing this earlier. Will review and ping you directly for clarification. Have some existing changes to merge to fix other azd issues so want to make sure these are complementary |
@nitya - these are complimentary, and we've discussed these changes. |
@tonybaloney - Can this be moved to avm instead? |
This PR removes core files that aren't used and updates the ones that are there from the latest version