Small changes based on PR review comments

Azure-Samples · Sep 28, 2023 · a248663 · a248663
1 parent 49c2327
commit a248663
Show file tree

Hide file tree

Showing 12 changed files with 38 additions and 10 deletions.
diff --git a/.github/workflows/Release-helm-dnsmasqaks.yml b/.github/workflows/Release-helm-dnsmasqaks.yml
@@ -26,7 +26,7 @@ jobs:
       with:
         version: v3.9.2
 
-    - name: Add Helm dependencies
+    - name: Add Helm chart dependencies
       run: |
         helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
         helm repo add grafana https://grafana.github.io/helm-charts

diff --git a/.github/workflows/Release-helm-edgeobservability.yml b/.github/workflows/Release-helm-edgeobservability.yml
@@ -26,7 +26,7 @@ jobs:
       with:
         version: v3.9.2
 
-    - name: Add Helm dependencies
+    - name: Add Helm chart dependencies
       run: |
         helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
         helm repo add grafana https://grafana.github.io/helm-charts

diff --git a/.github/workflows/Release-helm-envoy.yml b/.github/workflows/Release-helm-envoy.yml
@@ -26,7 +26,7 @@ jobs:
       with:
         version: v3.9.2
 
-    - name: Add Helm dependencies
+    - name: Add Helm chart dependencies
       run: |
         helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
         helm repo add grafana https://grafana.github.io/helm-charts

diff --git a/.github/workflows/Release-helm-iot-edge-l2.yml b/.github/workflows/Release-helm-iot-edge-l2.yml
@@ -26,7 +26,7 @@ jobs:
       with:
         version: v3.9.2
 
-    - name: Add Helm dependencies
+    - name: Add Helm chart dependencies
       run: |
         helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
         helm repo add grafana https://grafana.github.io/helm-charts

diff --git a/.github/workflows/Release-helm-iot-edge-l4.yml b/.github/workflows/Release-helm-iot-edge-l4.yml
@@ -26,7 +26,7 @@ jobs:
       with:
         version: v3.9.2
 
-    - name: Add Helm dependencies
+    - name: Add Helm chart dependencies
       run: |
         helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
         helm repo add grafana https://grafana.github.io/helm-charts

diff --git a/.github/workflows/Release-helm-mosquitto.yml b/.github/workflows/Release-helm-mosquitto.yml
@@ -26,7 +26,7 @@ jobs:
       with:
         version: v3.9.2
 
-    - name: Add Helm dependencies
+    - name: Add Helm chart dependencies
       run: |
         helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
         helm repo add grafana https://grafana.github.io/helm-charts

diff --git a/.github/workflows/Release-helm-otelcollection.yml b/.github/workflows/Release-helm-otelcollection.yml
@@ -26,7 +26,7 @@ jobs:
       with:
         version: v3.9.2
 
-    - name: Add Helm dependencies
+    - name: Add Helm chart dependencies
       run: |
         helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
         helm repo add grafana https://grafana.github.io/helm-charts

diff --git a/deployment/helm/edgeobservability/.helmignore b/deployment/helm/edgeobservability/.helmignore
@@ -0,0 +1,25 @@
+# Patterns to ignore when building packages.
+# This supports shell glob matching, relative path matching, and
+# negation (prefixed with !). Only one pattern per line.
+.DS_Store
+# Common VCS dirs
+.git/
+.gitignore
+.bzr/
+.bzrignore
+.hg/
+.hgignore
+.svn/
+# Common backup files
+*.swp
+*.bak
+*.tmp
+*.orig
+*~
+# Various IDEs
+.project
+.idea/
+*.tmproj
+.vscode/
+.tgz
+index.yaml
diff --git a/deployment/helm/edgeobservability/templates/grafana/grafana-k8s-dashboard.yaml b/deployment/helm/edgeobservability/templates/grafana/grafana-k8s-dashboard.yaml
@@ -1,3 +1,6 @@
+# This Grafana dashboard is based on the open source sample for Prometheus metrics for K8S
+# It can further be extended to include network layer specific filtering modes
+# See https://grafana.com/grafana/dashboards/315-kubernetes-cluster-monitoring-via-prometheus/
 apiVersion: v1
 kind: ConfigMap
 metadata:

diff --git a/deployment/helm/envoy/templates/NOTES.txt b/deployment/helm/envoy/templates/NOTES.txt
@@ -1,4 +1,4 @@
-You have installed release {{ .Chart.Version}} of {{ .Chart.Name }} of IoT Edge K8s Accelerator, pre-release version.
+You have installed release {{ .Chart.Version}} of {{ .Chart.Name }} of Envoy Proxy, pre-release version.
 
 To learn more about the release, try:
 

diff --git a/deployment/helm/iot-edge-l2/templates/NOTES.txt b/deployment/helm/iot-edge-l2/templates/NOTES.txt
@@ -1,4 +1,4 @@
-You have installed release {{ .Chart.Version}} of {{ .Chart.Name }} of IoT Edge K8s Accelerator, pre-release version.
+You have installed release {{ .Chart.Version}} of {{ .Chart.Name }} of IoT Edge Accelerator L2 (layer 2) on K8s, pre-release version.
 
 To learn more about the release, try:
 

diff --git a/deployment/helm/iot-edge-l4/templates/NOTES.txt b/deployment/helm/iot-edge-l4/templates/NOTES.txt
@@ -1,4 +1,4 @@
-You have installed release {{ .Chart.Version}} of {{ .Chart.Name }} of IoT Edge K8s Accelerator, pre-release version.
+You have installed release {{ .Chart.Version}} of {{ .Chart.Name }} of IoT Edge Accelerator L4 (layer 4) on K8s, pre-release version.
 
 To learn more about the release, try: