Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/observability: scripts and doc updates #65

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Feature/observability: scripts and doc updates #65

merged 6 commits into from
Oct 19, 2023

Conversation

katriendg
Copy link
Contributor

  • New doc linked from root README.MD to a document explaining the approach with observability in this repo
  • Changes in bicep to create Log Analytics and App Insights services when observability flag is enabled
  • Core-infrastructure script has the most changes to 1) deploy OpenTelemetry collector and related components in each level, 2) setup visualization with Grafana and related components in Level 4
  • Existing Helm charts have some changes (released in separate PR Observability - Helm chart releases #63) that allow passing in observability related settings and flags, these are now referenced in the scripts in this PR
  • Observability setup is enabled by default (Flux/demo bootstrap) but can be passed to the scripts with a new parameter $SetupObservability
    closes Platform Observability: adding observability for the solution #61

@katriendg katriendg added the enhancement New feature or request label Sep 29, 2023
bindsi
bindsi requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@bindsi bindsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work Katrien which is also a key to drive further customer conversations in that space! Thanks a lot!

deployment/deploy-core-infrastructure.ps1 Outdated Show resolved Hide resolved
docs/observability.md Outdated Show resolved Hide resolved
docs/observability.md Outdated Show resolved Hide resolved
docs/observability.md Outdated Show resolved Hide resolved
docs/observability.md Outdated Show resolved Hide resolved
@katriendg katriendg requested a review from bindsi October 9, 2023 12:37
bindsi
bindsi previously approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@bindsi bindsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for your updates

suneetnangia
suneetnangia reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@suneetnangia suneetnangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments for your review. Thanks.

docs/observability.md Show resolved Hide resolved
docs/observability.md Outdated Show resolved Hide resolved
docs/observability.md Show resolved Hide resolved
docs/observability.md Outdated Show resolved Hide resolved
docs/observability.md Outdated Show resolved Hide resolved
architecture/nested-topology-hld.png Outdated Show resolved Hide resolved
docs/observability.md Show resolved Hide resolved
deployment/bicep/core-infra-vnet.bicep Show resolved Hide resolved
deployment/bicep/core-infra-vnet.bicep Outdated Show resolved Hide resolved
deployment/deploy-dev-app-l2.ps1 Show resolved Hide resolved
suneetnangia
suneetnangia approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@suneetnangia suneetnangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done, thanks.

@katriendg katriendg merged commit 98e2639 into main Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suneetnangia suneetnangia suneetnangia approved these changes

@bindsi bindsi bindsi left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Platform Observability: adding observability for the solution
3 participants
@katriendg @suneetnangia @bindsi