-
Notifications
You must be signed in to change notification settings - Fork 77
Sekar/pc poc #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sekar/pc poc #50
Conversation
matthiasblondeel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my main question is why do we need the PATIENT_CONTEXT_JSON to be sent to the agents
The snapshot is programmatically generated, and agents don't need this information. Could we not get rid of it?
| Minimal per-patient context for patient isolation. | ||
| """ | ||
| patient_id: str | ||
| facts: Dict[str, Any] = field(default_factory=dict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these facts still used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now it is empty {} but the infrastructure is in place for when we add patient specific metadata if required so the agents do not have to re-parse the history. If we dont need we can remove this. I will ask lukas to d othat
| └─────────────┬─────────────────────────┘ | ||
| ↓ | ||
| ┌───────────────────────────────────────┐ | ||
| │ 5. Inject Fresh Snapshot │ ← Add system message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we still need this ephemeral/patient context for the agents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is primarily being used for agent grounding. while agents might be able to infer the patient identity through history the ephemeral snapshot ensures immediate and more accurate patient context. It also maintaints the session patients so that multiple use cases can be addressed. I will ask lukas to try without it but i think it might fail a few use cases. But we can definitely check it out
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
This is a draft PR for patient context management to ensure patient context is determined and maintained
How to Test
What to Check
Verify that the following are valid
Other Information