Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for PSRule for CAF #249

Merged
merged 8 commits into from
Apr 20, 2022
Merged

Adding support for PSRule for CAF #249

merged 8 commits into from
Apr 20, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Apr 11, 2022 •
edited
Loading

PR Summary

Closes #248

Just going to add to the BYO workflow file for the time being, until the PSRule for CAF module matures.

  • Fixes the template issue with PSRule for Azure that we had since removing the compiled json from the repo
  • Added support for PSRule for CAF
  • Added extra rule suppressions to PSRule config

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@Gordonby Gordonby added enhancement New feature or request ci-cd sample 🤖 Sample code in a GitHub action workflow labels Apr 11, 2022
@Gordonby Gordonby self-assigned this Apr 11, 2022
@Gordonby Gordonby temporarily deployed to azurecirgs April 11, 2022 11:21 Inactive
@Gordonby Gordonby requested a review from a team April 11, 2022 11:21
@Gordonby
Copy link
Collaborator Author

Linking these two together
microsoft/PSRule.Rules.CAF#98

@Gordonby Gordonby enabled auto-merge April 20, 2022 11:37
khowling
khowling approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition

@Gordonby Gordonby merged commit 1e2a7a7 into main Apr 20, 2022
@Gordonby Gordonby deleted the gb-caf branch April 20, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

Assignees

@Gordonby Gordonby

Labels
ci-cd sample 🤖 Sample code in a GitHub action workflow enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for PSRule for CAF
2 participants
@Gordonby @khowling