removing the feature flag

Azure · Apr 16, 2024 · 04cfba6 · 04cfba6
1 parent bcc67cf
commit 04cfba6
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 27 deletions.
diff --git a/docs/feature-flags.md b/docs/feature-flags.md
@@ -20,10 +20,6 @@ Subscription feature flags used by ARO-RP include:
   graduating features to production such that they only apply on our Red Hat
   engineering subscription.
 
-* Microsoft.RedHatOpenShift/SaveAROTestConfig: used on our test subscriptions to
-  cause the pkg/billing to copy billing data to a storage account so that it can
-  be validated by the billing E2E tests.
-
 Subscription feature flags are also used for API preview, INT and region
 rollout. See the RP ARM manifest for more details.
 

diff --git a/pkg/api/featureflags.go b/pkg/api/featureflags.go
@@ -4,11 +4,6 @@ package api
 // Licensed under the Apache License 2.0.
 
 const (
-	// FeatureFlagSaveAROTestConfig is the feature in the subscription that is used
-	// to indicate if we need to save ARO cluster config into the E2E
-	// StorageAccount
-	FeatureFlagSaveAROTestConfig = "Microsoft.RedHatOpenShift/SaveAROTestConfig"
-
 	// FeatureFlagMTU3900 is the feature in the subscription that causes new
 	// OpenShift cluster nodes to use the largest available Maximum Transmission
 	// Unit (MTU) on Azure virtual networks, which as of late 2021 is 3900 bytes.

diff --git a/pkg/util/billing/billing_test.go b/pkg/util/billing/billing_test.go
@@ -279,12 +279,6 @@ func TestEnsure(t *testing.T) {
 					ID: subID,
 					Subscription: &api.Subscription{
 						Properties: &api.SubscriptionProperties{
-							RegisteredFeatures: []api.RegisteredFeatureProfile{
-								{
-									Name:  api.FeatureFlagSaveAROTestConfig,
-									State: "NotRegistered",
-								},
-							},
 							TenantID: tenantID,
 						},
 					},
@@ -321,12 +315,6 @@ func TestEnsure(t *testing.T) {
 					ID: subID,
 					Subscription: &api.Subscription{
 						Properties: &api.SubscriptionProperties{
-							RegisteredFeatures: []api.RegisteredFeatureProfile{
-								{
-									Name:  api.FeatureFlagSaveAROTestConfig,
-									State: "NotRegistered",
-								},
-							},
 							TenantID: tenantID,
 						},
 					},
@@ -353,12 +341,6 @@ func TestEnsure(t *testing.T) {
 					ID: subID,
 					Subscription: &api.Subscription{
 						Properties: &api.SubscriptionProperties{
-							RegisteredFeatures: []api.RegisteredFeatureProfile{
-								{
-									Name:  api.FeatureFlagSaveAROTestConfig,
-									State: "NotRegistered",
-								},
-							},
 							TenantID: tenantID,
 						},
 					},