Skip to content

Commit

Permalink
Comment out converter and static validator for now - the linter doesn…
Browse files Browse the repository at this point in the history
…'t like them to exist without being used
  • Loading branch information
kimorris27 committed Apr 12, 2024
1 parent cb8b767 commit 28d0b60
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 12 deletions.
6 changes: 3 additions & 3 deletions pkg/api/admin/platformworkloadidentityroleset_convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ package admin
// Copyright (c) Microsoft Corporation.
// Licensed under the Apache License 2.0.

import (
"github.com/Azure/ARO-RP/pkg/api"
)
/*
TODO: Uncomment once API endpoints have been implemented and this code is being used.
type platformWorkloadIdentityRoleSetConverter struct{}
Expand Down Expand Up @@ -65,3 +64,4 @@ func (c platformWorkloadIdentityRoleSetConverter) ToInternal(_new interface{}, o
out.Properties.PlatformWorkloadIdentityRoles[i].ServiceAccounts = append(out.Properties.PlatformWorkloadIdentityRoles[i].ServiceAccounts, r.ServiceAccounts...)
}
}
*/
13 changes: 4 additions & 9 deletions pkg/api/admin/platformworkloadidentityroleset_validatestatic.go
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
package admin

import (
"errors"
"fmt"
"net/http"

"github.com/Azure/ARO-RP/pkg/api"
"github.com/Azure/ARO-RP/pkg/api/util/immutable"
)

// Copyright (c) Microsoft Corporation.
// Licensed under the Apache License 2.0.

/*
TODO: Uncomment once API endpoints have been implemented and this code is being used.
type platformWorkloadIdentityRoleSetStaticValidator struct{}
func (sv platformWorkloadIdentityRoleSetStaticValidator) Static(_new interface{}, _current *api.PlatformWorkloadIdentityRoleSet) error {
Expand Down Expand Up @@ -70,3 +64,4 @@ func (sv platformWorkloadIdentityRoleSetStaticValidator) validateDelta(new, curr
}
return nil
}
*/

0 comments on commit 28d0b60

Please sign in to comment.