use switch statements

Azure · Jul 5, 2023 · 386ce5b · 386ce5b
1 parent cdb3d4f
commit 386ce5b
Showing 1 changed file with 21 additions and 10 deletions.
diff --git a/pkg/api/admin/openshiftcluster_validatestatic.go b/pkg/api/admin/openshiftcluster_validatestatic.go
@@ -41,24 +41,35 @@ func (sv openShiftClusterStaticValidator) validateDelta(oc, current *OpenShiftCl
 }
 
 func invalidMaintenanceTask(task MaintenanceTask) bool {
-	if task == "" ||
-		task == MaintenanceTaskEverything ||
-		task == MaintenanceTaskOperator ||
-		task == MaintenanceTaskRenewCerts ||
-		task == MaintenanceTaskStateUpdate {
+	switch task {
+	case "":
+		fallthrough
+	case MaintenanceTaskEverything:
+		fallthrough
+	case MaintenanceTaskOperator:
+		fallthrough
+	case MaintenanceTaskRenewCerts:
+		fallthrough
+	case MaintenanceTaskStateUpdate:
 		return false
 	}
 
 	return true
 }
 
 func invalidMaintenanceState(state MaintenanceState) bool {
-	if state == "" ||
-		state == MaintenanceStateNone ||
-		state == MaintenanceStatePending ||
-		state == MaintenanceStatePlanned ||
-		state == MaintenanceStateUnplanned {
+	switch state {
+	case "":
+		fallthrough
+	case MaintenanceStateNone:
+		fallthrough
+	case MaintenanceStatePending:
+		fallthrough
+	case MaintenanceStatePlanned:
+		fallthrough
+	case MaintenanceStateUnplanned:
 		return false
+
 	}
 
 	return true