Skip to content

Commit

Permalink
Return error if we fail to delete hive resources during deletion
Browse files Browse the repository at this point in the history
  • Loading branch information
bennerv committed Sep 19, 2023
1 parent 4255225 commit 4ae414c
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions pkg/cluster/delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -495,12 +495,7 @@ func (m *manager) Delete(ctx context.Context) error {
}

if m.adoptViaHive || m.installViaHive {
// Don't fail the deletion because of hive
// This should change when/if we start using hive for cluster deletion
err = m.hiveDeleteResources(ctx)

Check failure on line 498 in pkg/cluster/delete.go

View workflow job for this annotation

GitHub Actions / golangci-lint

SA4006: this value of `err` is never used (staticcheck)
if err != nil {
m.log.Info(err)
}
}

return m.billing.Delete(ctx, m.doc)
Expand Down

0 comments on commit 4ae414c

Please sign in to comment.