Merge pull request #3715 from Azure/hawkowl/fix-lint-errs-jul24

Clean up some lint errors found on golangci-lint 1.59.1

pkg/api/openshiftcluster.go

@@ -531,8 +531,8 @@ const (
 )
 
 type VMSizeStruct struct {
-	CoreCount int
-	Family    string
+	CoreCount int    `json:"coreCount,omitempty"`
+	Family    string `json:"family,omitempty"`
 }
 
 var (

pkg/portal/cluster/nodes.go

@@ -27,15 +27,15 @@ type Taint struct {
 }
 
 type MachineResources struct {
-	CPU           string
-	StorageVolume string
-	Memory        string
-	Pods          string
+	CPU           string `json:"cpu"`
+	StorageVolume string `json:"storageVolume"`
+	Memory        string `json:"memory"`
+	Pods          string `json:"pods"`
 }
 
 type Volume struct {
-	Name string
-	Path string
+	Name string `json:"name"`
+	Path string `json:"path"`
 }
 
 type NodeInformation struct {

pkg/util/azureclient/applens/applens_client.go

@@ -198,7 +198,7 @@ func (c *Client) executeAndEnsureSuccessResponse(request *policy.Request) (*http
 		return nil, err
 	}
 
-	successResponse := (response.StatusCode >= 200 && response.StatusCode < 300) || response.StatusCode == 304
+	successResponse := (response.StatusCode >= 200 && response.StatusCode < 300) || response.StatusCode == http.StatusNotModified
 	if successResponse {
 		return response, nil
 	}