Skip to content

Commit

Permalink
Enable autonodezing by default
Browse files Browse the repository at this point in the history
  • Loading branch information
petrkotas committed Sep 11, 2023
1 parent e02f5e0 commit 99fff68
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/api/defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func DefaultOperatorFlags() OperatorFlags {
"aro.routefix.enabled": flagTrue,
"aro.storageaccounts.enabled": flagTrue,
"aro.workaround.enabled": flagTrue,
"aro.autosizednodes.enabled": flagFalse,
"aro.autosizednodes.enabled": flagTrue,
"rh.srep.muo.enabled": flagTrue,
"rh.srep.muo.managed": flagTrue,
"aro.guardrails.enabled": flagFalse,
Expand Down
8 changes: 6 additions & 2 deletions pkg/monitor/cluster/clusterflagsandbanner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package cluster

import (
"context"
"fmt"
"reflect"
"testing"

Expand Down Expand Up @@ -54,12 +55,15 @@ func generateDefaultFlags() arov1alpha1.OperatorFlags {
func generateNonStandardFlags(nonDefualtFlagNames []string) arov1alpha1.OperatorFlags {
nsf := make(arov1alpha1.OperatorFlags)
for k, v := range api.DefaultOperatorFlags() {
fmt.Println(k, v)
nsf[k] = v
}
for _, n := range nonDefualtFlagNames {
if nsf[n] == "true" {
fmt.Println(n, "false")
nsf[n] = "false"
} else {
fmt.Println(n, "false")
nsf[n] = "true"
}
}
Expand Down Expand Up @@ -126,7 +130,7 @@ func TestEmitOperatorFlagsAndSupportBanner(t *testing.T) {
"aro.imageconfig.enabled": "false",
"aro.dnsmasq.enabled": "false",
"aro.genevalogging.enabled": "false",
"aro.autosizednodes.enabled": "true",
"aro.autosizednodes.enabled": "false",
},
expectBannerMetricsValue: 0,
expectBannerMetricsDims: nil,
Expand Down Expand Up @@ -169,7 +173,7 @@ func TestEmitOperatorFlagsAndSupportBanner(t *testing.T) {
"aro.imageconfig.enabled": "false",
"aro.dnsmasq.enabled": "false",
"aro.genevalogging.enabled": "false",
"aro.autosizednodes.enabled": "true",
"aro.autosizednodes.enabled": "false",
},
expectBannerMetricsValue: 1,
expectBannerMetricsDims: map[string]string{"msg": "contact support"},
Expand Down

0 comments on commit 99fff68

Please sign in to comment.