rename to be a bit more sensical and add logs

Azure · Jul 8, 2024 · c2e5526 · c2e5526
1 parent 1e9a5af
commit c2e5526
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/pkg/cluster/failurediagnostics/virtualmachines.go b/pkg/cluster/failurediagnostics/virtualmachines.go
@@ -12,7 +12,9 @@ import (
 	"github.com/Azure/ARO-RP/pkg/util/stringutils"
 )
 
-func (m *manager) LogAzureInformation(ctx context.Context) (interface{}, error) {
+// LogSerialConsoleVMLogs fetches the serial console from VMs and logs them with
+// the associated VM name.
+func (m *manager) LogSerialConsoleVMLogs(ctx context.Context) (interface{}, error) {
 	items := make([]interface{}, 0)
 
 	if m.virtualMachines == nil {

diff --git a/pkg/cluster/failurediagnostics/virtualmachines_test.go b/pkg/cluster/failurediagnostics/virtualmachines_test.go
@@ -24,7 +24,7 @@ import (
 	testlog "github.com/Azure/ARO-RP/test/util/log"
 )
 
-func TestVirtualMachines(t *testing.T) {
+func TestVirtualMachinesSerialConsole(t *testing.T) {
 	const (
 		key            = "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/resourceGroup/providers/Microsoft.RedHatOpenShift/openShiftClusters/resourceName1"
 		clusterProfile = "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/resourceGroupCluster"
@@ -150,7 +150,7 @@ func TestVirtualMachines(t *testing.T) {
 				virtualMachines: vmClient,
 			}
 
-			out, err := d.LogAzureInformation(ctx)
+			out, err := d.LogSerialConsoleVMLogs(ctx)
 			if err != nil {
 				t.Errorf("returned %s, should never return an error", err)
 			}

diff --git a/pkg/cluster/gatherlogs.go b/pkg/cluster/gatherlogs.go
@@ -26,7 +26,7 @@ func (m *manager) gatherFailureLogs(ctx context.Context) {
 		{f: m.logNodes, isJSON: true},
 		{f: m.logClusterOperators, isJSON: true},
 		{f: m.logIngressControllers, isJSON: true},
-		{f: d.LogAzureInformation, isJSON: false},
+		{f: d.LogSerialConsoleVMLogs, isJSON: false},
 	} {
 		o, err := f.f(ctx)
 		if err != nil {