Skip to content

Commit

Permalink
Use a mix of addressPrefix and addressPrefixes in e2e
Browse files Browse the repository at this point in the history
This should allow us to catch any issues with using one over the other,
since both are valid configurations on both vnets and subnets in Azure.
  • Loading branch information
bennerv authored and cadenmarchese committed Sep 11, 2023
1 parent 8afd0b2 commit c4cf22a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion pkg/deploy/assets/cluster-development-predeploy.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@
},
{
"properties": {
"addressPrefix": "[parameters('masterAddressPrefix')]",
"addressPrefixes": [
"[parameters('masterAddressPrefix')]"
],
"routeTable": {
"id": "[resourceid('Microsoft.Network/routeTables', concat(parameters('clusterName'), '-rt'))]",
"tags": null
Expand Down
4 changes: 3 additions & 1 deletion pkg/deploy/generator/resources_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ func (g *generator) clusterMasterSubnet() *arm.Resource {
return &arm.Resource{
Resource: &mgmtnetwork.Subnet{
SubnetPropertiesFormat: &mgmtnetwork.SubnetPropertiesFormat{
AddressPrefix: to.StringPtr("[parameters('masterAddressPrefix')]"),
AddressPrefixes: &[]string{
*to.StringPtr("[parameters('masterAddressPrefix')]"),
},
RouteTable: &mgmtnetwork.RouteTable{
ID: to.StringPtr("[resourceid('Microsoft.Network/routeTables', concat(parameters('clusterName'), '-rt'))]"),
},
Expand Down

0 comments on commit c4cf22a

Please sign in to comment.