Skip to content

Commit

Permalink
updating to mgmt/storage/2021-09-01 for allowSharedKeyAccess field su…
Browse files Browse the repository at this point in the history
…pport
  • Loading branch information
azoppiserpa committed May 28, 2024
1 parent 726b7b0 commit c6705ca
Show file tree
Hide file tree
Showing 30 changed files with 16,602 additions and 3 deletions.
3 changes: 3 additions & 0 deletions pkg/deploy/assets/rp-production.json
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,9 @@
"sku": {
"name": "Standard_LRS"
},
"properties": {
"allowSharedKeyAccess": false
},
"location": "[resourceGroup().location]",
"name": "[substring(parameters('storageAccountDomain'), 0, indexOf(parameters('storageAccountDomain'), '.'))]",
"type": "Microsoft.Storage/storageAccounts",
Expand Down
2 changes: 1 addition & 1 deletion pkg/deploy/generator/resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
mgmtkeyvault "github.com/Azure/azure-sdk-for-go/services/keyvault/mgmt/2019-09-01/keyvault"
mgmtnetwork "github.com/Azure/azure-sdk-for-go/services/network/mgmt/2020-08-01/network"
mgmtinsights "github.com/Azure/azure-sdk-for-go/services/preview/monitor/mgmt/2018-03-01/insights"
mgmtstorage "github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2019-06-01/storage"
mgmtstorage "github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage"
"github.com/Azure/go-autorest/autorest/to"

"github.com/Azure/ARO-RP/pkg/util/arm"
Expand Down
7 changes: 5 additions & 2 deletions pkg/deploy/generator/resources_rp.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
mgmtauthorization "github.com/Azure/azure-sdk-for-go/services/preview/authorization/mgmt/2018-09-01-preview/authorization"
mgmtcontainerregistry "github.com/Azure/azure-sdk-for-go/services/preview/containerregistry/mgmt/2020-11-01-preview/containerregistry"
mgmtinsights "github.com/Azure/azure-sdk-for-go/services/preview/monitor/mgmt/2018-03-01/insights"
mgmtstorage "github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2019-06-01/storage"
mgmtstorage "github.com/Azure/azure-sdk-for-go/services/storage/mgmt/2021-09-01/storage"
"github.com/Azure/go-autorest/autorest/to"

"github.com/Azure/ARO-RP/pkg/env"
Expand Down Expand Up @@ -1561,5 +1561,8 @@ func (g *generator) rpVersionStorageAccount() []*arm.Resource {
}

func (g *generator) rpStorageAccount() *arm.Resource {
return g.storageAccount("[substring(parameters('storageAccountDomain'), 0, indexOf(parameters('storageAccountDomain'), '.'))]", nil, nil)
accountProperties := mgmtstorage.AccountProperties{
AllowSharedKeyAccess: to.BoolPtr(false),
}
return g.storageAccount("[substring(parameters('storageAccountDomain'), 0, indexOf(parameters('storageAccountDomain'), '.'))]", &accountProperties, nil)
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit c6705ca

Please sign in to comment.