Skip to content

Commit

Permalink
Change env var to skip pki unit tests (#3605)
Browse files Browse the repository at this point in the history
  • Loading branch information
bitoku authored Jun 5, 2024
1 parent cc5d9b2 commit e34a95b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Dockerfile.ci-rp
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ RUN go build -ldflags "-X github.com/Azure/ARO-RP/pkg/util/version.GitCommit=${A
RUN go test ./test/e2e/... -tags e2e,codec.safe -c -ldflags "-X github.com/Azure/ARO-RP/pkg/util/version.GitCommit=${ARO_VERSION}" -o e2e.test

# Additional tests
RUN ARO_RUN_PKI_TESTS=nope go run gotest.tools/[email protected] --format pkgname --junitfile report.xml -- -coverprofile=cover.out ./...
RUN ARO_SKIP_PKI_TESTS=true go run gotest.tools/[email protected] --format pkgname --junitfile report.xml -- -coverprofile=cover.out ./...
RUN hack/fips/validate-fips.sh ./aro

###############################################################################
Expand Down
2 changes: 2 additions & 0 deletions env.example
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@ export ARO_IMAGE=arointsvc.azurecr.io/aro:latest
export NO_CACHE=false
export AZURE_EXTENSION_DEV_SOURCES="$(pwd)/python"

export ARO_SKIP_PKI_TESTS=true

. secrets/env
2 changes: 1 addition & 1 deletion pkg/util/pki/pki_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
)

func TestGetTlsConfig(t *testing.T) {
if os.Getenv("ARO_RUN_PKI_TESTS") != "" {
if os.Getenv("ARO_SKIP_PKI_TESTS") != "" {
t.Skip("")
}
kpiUrl := "https://issuer.pki.azure.com/dsms/issuercertificates?getissuersv3&caName=%s"
Expand Down

0 comments on commit e34a95b

Please sign in to comment.