validate static refactor

Azure · Jul 18, 2023 · ebb825e · ebb825e
1 parent d563aee
commit ebb825e
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/pkg/api/admin/openshiftcluster_validatestatic.go b/pkg/api/admin/openshiftcluster_validatestatic.go
@@ -29,11 +29,15 @@ func (sv openShiftClusterStaticValidator) validateDelta(oc, current *OpenShiftCl
 		return api.NewCloudError(http.StatusBadRequest, api.CloudErrorCodePropertyChangeNotAllowed, err.Target, err.Message)
 	}
 
-	if !(oc.Properties.MaintenanceTask == "" ||
-		oc.Properties.MaintenanceTask == MaintenanceTaskEverything ||
-		oc.Properties.MaintenanceTask == MaintenanceTaskOperator ||
-		oc.Properties.MaintenanceTask == MaintenanceTaskRenewCerts ||
-		oc.Properties.MaintenanceTask == MaintenanceTaskPucmPending) {
+	return validateMaintenanceTask(oc.Properties.MaintenanceTask)
+}
+
+func validateMaintenanceTask(task MaintenanceTask) error {
+	if !(task == "" ||
+		task == MaintenanceTaskEverything ||
+		task == MaintenanceTaskOperator ||
+		task == MaintenanceTaskRenewCerts ||
+		task == MaintenanceTaskPucmPending) {
 		return api.NewCloudError(http.StatusBadRequest, api.CloudErrorCodeInvalidParameter, "properties.maintenanceTask", "Invalid enum parameter.")
 	}