ARO-9711 update Blob Client naming and comments

Azure · Oct 9, 2024 · eea3e5d · eea3e5d
1 parent b5d82ac
commit eea3e5d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 17 deletions.
diff --git a/pkg/util/azureclient/azuresdk/azblob/blobs.go b/pkg/util/azureclient/azuresdk/azblob/blobs.go
@@ -29,7 +29,7 @@ type blobsClient struct {
 
 var _ BlobsClient = &blobsClient{}
 
-// NewBlobsClient creates a new BlobsClient using SAS
+// NewBlobsClientUsingSAS creates a new BlobsClient using SAS
 func NewBlobsClientUsingSAS(ctx context.Context, environment *azureclient.AROEnvironment, sasURL string) (*blobsClient, error) {
 	customRoundTripper := azureclient.NewCustomRoundTripper(http.DefaultTransport)
 
@@ -51,7 +51,8 @@ func NewBlobsClientUsingSAS(ctx context.Context, environment *azureclient.AROEnv
 	}, nil
 }
 
-func NewBlobsClient(ctx context.Context, environment *azureclient.AROEnvironment, serviceURL string, credential azcore.TokenCredential) (*blobsClient, error) {
+// NewBlobsClientUsingEntra creates a new BlobsClient Microsoft Entra credentials
+func NewBlobsClientUsingEntra(ctx context.Context, environment *azureclient.AROEnvironment, serviceURL string, credential azcore.TokenCredential) (*blobsClient, error) {
 	customRoundTripper := azureclient.NewCustomRoundTripper(http.DefaultTransport)
 
 	options := &azblob.ClientOptions{

diff --git a/pkg/util/mocks/env/env.go b/pkg/util/mocks/env/env.go
diff --git a/pkg/util/storage/manager.go b/pkg/util/storage/manager.go
@@ -74,7 +74,7 @@ func getCorrectErrWhenTooManyRequests(err error) error {
 func (m *manager) BlobService(ctx context.Context, resourceGroup, account string, p storagesdk.Permissions, r storagesdk.SignedResourceTypes) (blobClient azblob.BlobsClient, err error) {
 	serviceURL := fmt.Sprintf("https://%s.blob.%s", account, m.env.Environment().StorageEndpointSuffix)
 	if m.usesWorkloadIdentity {
-		blobClient, err = azblob.NewBlobsClient(ctx, m.env.Environment(), serviceURL, m.credential)
+		blobClient, err = azblob.NewBlobsClientUsingEntra(ctx, m.env.Environment(), serviceURL, m.credential)
 		if err != nil {
 			return nil, err
 		}