Skip to content

Commit

Permalink
pkg/cluster: Use Action for fixupClusterSPObjectID
Browse files Browse the repository at this point in the history
  • Loading branch information
ehvs committed Jul 16, 2024
1 parent d9800f0 commit ffca22b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion pkg/cluster/adminupdate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func TestAdminUpdateSteps(t *testing.T) {
"[Action initializeKubernetesClients]",
"[Action ensureBillingRecord]",
"[Action ensureDefaults]",
"[AuthorizationRetryingAction fixupClusterSPObjectID]",
"[Action fixupClusterSPObjectID]",
"[Action fixInfraID]",
}

Expand Down
6 changes: 1 addition & 5 deletions pkg/cluster/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,7 @@ func (m *manager) getZerothSteps() []steps.Step {
steps.Action(m.initializeKubernetesClients), // must be first
steps.Action(m.ensureBillingRecord), // belt and braces
steps.Action(m.ensureDefaults),

// TODO: this relies on an authorizer that isn't exposed in the manager
// struct, so we'll rebuild the fpAuthorizer and use the error catching
// to advance
steps.AuthorizationRetryingAction(m.fpAuthorizer, m.fixupClusterSPObjectID),
steps.Action(m.fixupClusterSPObjectID),
}

// Generic fix-up actions that are fairly safe to always take, and don't require a running cluster
Expand Down

0 comments on commit ffca22b

Please sign in to comment.