Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API OperatorFlagsMergeStrategy #2753

Closed
wants to merge 1 commit into from
Closed

API OperatorFlagsMergeStrategy #2753

wants to merge 1 commit into from

Conversation

SrinivasAtmakuri
Copy link
Collaborator

JIRA: https://issues.redhat.com/browse/ARO-1885

Which issue this PR addresses:

Fixes

What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

@SrinivasAtmakuri SrinivasAtmakuri added the skippy pull requests raised by member of Team Skippy label Mar 1, 2023
@SrinivasAtmakuri SrinivasAtmakuri marked this pull request as ready for review April 20, 2023 13:49
@bennerv
Copy link
Collaborator

bennerv commented Apr 20, 2023 •
edited
Loading

Is there a reason we need a flag to merge these? IMO it should be default behavior to take whatever is present within the cluster document + whatever our defaults are, and merge them together.

I don't really like adding additional series of flags because they're slowly getting out of control.

Essentially my question would be: do we see ourselves ever using the "reset" functionality? If so, I understand the change, but I don't know when we'd ever purposefully use it.

@hawkowl what are your thoughts?

petrkotas
petrkotas requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@petrkotas petrkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SrinivasAtmakuri I have two questions and one humble request. Would you please cover this function with unit test to verify it is doing what is expected? Thank you

pkg/api/admin/operatorflags.go Show resolved Hide resolved
pkg/api/admin/operatorflags.go Outdated Show resolved Hide resolved
petrkotas
petrkotas reviewed Aug 4, 2023
View reviewed changes
pkg/api/admin/operatorflags_test.go
OperatorFlags: api.OperatorFlags{"aro.feature1.enabled": "false"},
},
},
body: []byte(`{"operatorflagsmergestrategy":"merge"}`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SrinivasAtmakuri would you please also add the reset strategy, to make it explicit and show that it works please?

@SrinivasAtmakuri
Copy link
Collaborator Author

Adding more test cases and retesting the code. Will update once done. Thanks.

@SrinivasAtmakuri
Copy link
Collaborator Author

deprioritized, marking this RP for closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyu74 xiaoyu74 xiaoyu74 left review comments

@petrkotas petrkotas petrkotas requested changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@facchettos facchettos Awaiting requested review from facchettos

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@s-amann s-amann Awaiting requested review from s-amann

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@ellis-johnson ellis-johnson Awaiting requested review from ellis-johnson

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@Shivkumar13 Shivkumar13 Awaiting requested review from Shivkumar13

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@dofinn dofinn Awaiting requested review from dofinn

Assignees

@SrinivasAtmakuri SrinivasAtmakuri

Labels
skippy pull requests raised by member of Team Skippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SrinivasAtmakuri @bennerv @hawkowl @xiaoyu74 @petrkotas