Propagate errors of ARO DNSMasqMachineConfigPool controller #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SrinivasAtmakuri
force-pushed
the
ARO-3255
branch
from
8c8ee58
to
c5db0bd
Compare
SrinivasAtmakuri
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
SrinivasAtmakuri
added
ready-for-review
skippy
tsatam
requested changes
Jul 6, 2023
pkg/operator/controllers/dnsmasq/machineconfigpool_controller_test.go
Outdated
Show resolved
Hide resolved
SrinivasAtmakuri
force-pushed
the
ARO-3255
branch
from
c5db0bd
to
7f01f35
Compare
tsatam
previously approved these changes
Jul 10, 2023
SudoBrendan
previously approved these changes
Jul 11, 2023
Comment on lines
158
to
159
| ctx := context.Background() | ||
| _, err := r.Reconcile(context.Background(), tt.request) |
There was a problem hiding this comment.
nit: Same as the other PR - I'd like to see either ctx or context.Background() instead of this hybrid.
jaitaiwan
previously approved these changes
Jul 12, 2023
yjst2012
previously approved these changes
Jul 12, 2023
SrinivasAtmakuri
dismissed stale reviews from yjst2012, jaitaiwan, SudoBrendan, and tsatam
via
ecc2e97
SrinivasAtmakuri
force-pushed
the
ARO-3255
branch
from
7f01f35
to
ecc2e97
Compare
yjst2012
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate errors of ARO DNSMasqMachineConfigPool controller to ARO Operator
Jira: https://issues.redhat.com/browse/ARO-3255
Which issue this PR addresses:
Fixes
What this PR does / why we need it:
Test plan for issue:
Is there any documentation that needs to be updated for this PR?