Add tests for clusteroperatoraro controller #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan and
ellis-johnson
as code owners
SudoBrendan
previously approved these changes
Jul 11, 2023
|
I added a test to ensure we do not set Degraded=True on the operator when controller Degraded=True conditions are present. |
SudoBrendan
approved these changes
Jul 19, 2023
cadenmarchese
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
None
What this PR does / why we need it:
Add additional test coverage for the clusteroperatoraro controller, responsible for populating the ARO Cluster Operator resource.
The tests specifically cover the issue found and fixed in #2903 by validating that the version remains set on the resource on all Reconcile scenarios.
Test plan for issue:
The PR is just tests
Is there any documentation that needs to be updated for this PR?
No.