Fixing ARO API to enable Terraform Provider for ARO #2983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamMN
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
s-amann,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
|
i think it'd be okay to summarize the outcome from design doc in the PR body. In particular, that table in page 6. |
weinong
reviewed
Jun 26, 2023
weinong
reviewed
Jun 26, 2023
weinong
reviewed
Jun 26, 2023
weinong
reviewed
Jun 26, 2023
weinong
reviewed
Jun 26, 2023
...t/resource-manager/Microsoft.RedHatOpenShift/preview/2023-07-01-preview/redhatopenshift.json
Outdated
Show resolved
Hide resolved
facchettos
previously requested changes
Jun 28, 2023
gouthamMN
added
next-release
s-amann
previously approved these changes
Jul 5, 2023
|
Hey, I'm adding a |
|
Please rebase pull request. |
gouthamMN
force-pushed
the
master
branch
2 times, most recently
from
6bed9c1
to
220c6ff
Compare
|
These changes are moved to new PR #3053 |
datianshi
added a commit
to rh-mobb/terraform-provider-azureopenshift
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-2124
What this PR does / why we need it:
OpenShiftCluster GET API returns enriched worker profile data under a new field "workerProfilesStatus". This change is introduced only to new API. More details can be found on Design Doc
Any API call made to endpoints /openShiftClusters or /openShiftCluster with GET method using newer API versions (>= v2023-07-01-preview) will return the enriched worker profile data under a new field "workerProfilesStatus" in the response and "workerProfiles" filed will contain the last input that was passed in PUT/PATCH request body for cluster creation or update.
The response and behavior of any older APIs versions (< v2023-07-01-preview) remain unchanged i.e, only "workerProfiles" filed exists in the response.
Test plan for issue:
Existing unit tests and E2E test copied over from previous API.
Is there any documentation that needs to be updated for this PR?
N/A