Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance Signals #2991

Closed
wants to merge 13 commits into from
Closed

Maintenance Signals #2991

wants to merge 13 commits into from

Conversation

niontive
Copy link
Collaborator

@niontive niontive commented Jun 26, 2023 •
edited
Loading

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-1933

What this PR does / why we need it:

This PR is needed to allow for ARO SREs to send signals when cluster maintenance is being performed. Those signals will go to resource health check so customers get notified.

Code changes:

  1. Add maintenance states to CosmosDB cluster document
  2. Add maintenance state admin update task
  3. Emit metric via monitoring stack. Metric lists the cluster's maintenance state.

More info can be found here: https://msazure.visualstudio.com/AzureRedHatOpenShift/_wiki/wikis/AzureRedHatOpenShift.wiki/508199/Maintenance-Signals

Test plan for issue:

  • Unit tests
  • Tested in INT

Is there any documentation that needs to be updated for this PR?

@niontive niontive marked this pull request as ready for review July 5, 2023 15:21
@niontive niontive added next-release To be included in the next RP release rollout ready-for-review labels Jul 5, 2023
@niontive
Copy link
Collaborator Author

niontive commented Jul 5, 2023

Code review:

  1. Review design with ben/rogerio
  2. Investigate using middleware so you don't have to modify a bunch of ARO-SRE scripts

@niontive niontive closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@facchettos facchettos Awaiting requested review from facchettos

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@s-amann s-amann Awaiting requested review from s-amann

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@ellis-johnson ellis-johnson Awaiting requested review from ellis-johnson

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

Assignees
No one assigned
Labels
next-release To be included in the next RP release rollout ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niontive