Add static preflight validation #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carvalhe
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
|
Please rebase pull request. |
weinong
reviewed
Jul 10, 2023
weinong
reviewed
Jul 10, 2023
weinong
reviewed
Jul 10, 2023
s-amann
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-1945
What this PR does / why we need it:
After validating what the arm payload looks like for preflight, this PR adds static validation to preflight, as well as small changes suggested in the last PR. Once this is done, we can update the manifest disable test only parameter and have preflight running on live. This will speed up the process for validation as it is done before deployment. The more tests that move to preflight, the better.
Test plan for issue:
Will look at logs before making manifest changes, as well as checking INT env.