Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v20230701preview API changes for NSG Enhancement #3006

Closed
wants to merge 1 commit into from

Conversation

nwnt
Copy link
Contributor

@nwnt nwnt commented Jul 4, 2023

Which issue this PR addresses:

Fixes ARO-3494

What this PR does / why we need it:

Add a new API field called preconfiguredNSG for NSG Enhancement

Test plan for issue:

Tested using the local development environment. Could see that the new field was sent and received properly with the changes included in the PR.

Is there any documentation that needs to be updated for this PR?

N/A

@nwnt nwnt force-pushed the nsg-enhancement-preview-api branch from 9dab51e to dd94bb2 Compare July 5, 2023 22:36
@SudoBrendan SudoBrendan added the hold Hold label Jul 11, 2023
@SudoBrendan
Copy link
Collaborator

Hey, I'm adding a hold on this since it looks like we might be changing up what API version this lands in. Please reach out if you have any questions.

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Jul 21, 2023
@github-actions
Copy link

Please rebase pull request.

1 similar comment
@github-actions
Copy link

Please rebase pull request.

@nwnt nwnt mentioned this pull request Jul 26, 2023
@bennerv
Copy link
Collaborator

bennerv commented Jul 26, 2023

Abandoning in favor of #3062

@bennerv bennerv closed this Jul 26, 2023
@cblecker cblecker deleted the nsg-enhancement-preview-api branch September 15, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants