Lint Go Caveats

[jaitaiwan]

In almost all cases, checking to see if an interface is nil is an anti-practice that can land the coder in hot water.

As documented in this simple Go playground, the average coder would expect that when removing line 26, the conditional check of a == nil would result in true however this is the opposite of what happens:
https://go.dev/play/p/WdL4mKbocyY?v=goprev

This is due to a known function of Go but it's almost definite that coders working on the ARO-RP will have introduced this in many places in the repository and they are yet to bite us.

This PR creates a custom linting rule that checks for where this may happen and raises a warning to alert the coder that this is probably not meant to be there. In the future this should be set to an error which can be ignored on a case-by-case basis.

Internal reference: ARO-3463

[github-actions]

Please rebase pull request.

[jaitaiwan]

Found that the linting effort I was trying to do was impossible. Closing it out as wont-do.