Revert "Add API Server Reachability Check (#2959)" #3016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 629913b.
s-amann
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
s-amann
added
next-release
bennerv
approved these changes
Jul 11, 2023
niontive
approved these changes
Jul 11, 2023
cadenmarchese
approved these changes
Jul 11, 2023
|
Please rebase pull request. |
|
No longer needed since we merged #3017, which contains the commit here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 629913b.
Which issue this PR addresses:
Fixes issue with new ping check requiring change of geneva monitors, a new PR will be opened to still have healthz be first and fallback to ping.
What this PR does / why we need it:
Test plan for issue:
Is there any documentation that needs to be updated for this PR?