Add more information to on conflict for gateway PE linkId #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennerv
requested review from
jewzaam,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Will help identify issues with cluster errors for linkId conflicts.
https://issues.redhat.com/browse/ARO-3750
What this PR does / why we need it:
This will have more verbose error logging for us to be able to connect if a linkId is being reused on cluster installation failures, or if Azure has a bug with linkId reuse.
Background
We're still seeing cluster installations fail because of this error message, and we don't log the linkId anywhere so we don't know which cluster it is conflicting with. This will explicitly error out which cluster has the conflict and what the linkID is, so we can go in and examine if there's a race condition in our code, or if we need to file a bug with the NRP team.