Unplanned Maintenance Signals #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niontive
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
ellis-johnson,
yjst2012 and
anshulvermapatel
as code owners
niontive
commented
Jul 26, 2023
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
s-amann
reviewed
Aug 15, 2023
s-amann
reviewed
Aug 16, 2023
s-amann
previously approved these changes
Aug 17, 2023
cadenmarchese
previously approved these changes
Aug 17, 2023
jhoreman
previously approved these changes
Aug 21, 2023
|
Please rebase pull request. |
niontive
dismissed stale reviews from jhoreman, cadenmarchese, and s-amann
via
e7e16d6
|
Rebased with master due to merge conflict. |
cadenmarchese
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-1933
What this PR does / why we need it:
For resource health check, we have to emit a metric when we're doing unplanned maintenance on a cluster. This code changes accomplishes this by:
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
No - everything is automated