Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hack script to build hive install-log-regexes from ARO definition #3098

Closed

Conversation

tsatam
Copy link
Collaborator

@tsatam tsatam commented Aug 15, 2023

This is a spike PR to evaluate feasibility/desirability of a "single source of truth" for our install failure definitions, which can then be used by both our Hive setup as well as the RP. It should not be merged as-is for now.

Which issue this PR addresses:

Building block for ARO-3220

What this PR does / why we need it:

  • Adds a definition for ARO-specific install failure reasons, maintained in Go, that defines specific regular expressions to identify reasons from a failed install's log.
  • Adds a hack script to build a Hive additional-install-log-regexes ConfigMap, to supersede the default rules provided by Hive with ARO/Azure-specific cases, populated from the above definitions.

This work item will eventually involve building RP-side handling for these install failures, to directly alert customers when the reason is customer-inflicted, that will also build off of these definitions. The work will either be a part of a future PR or future commits on this branch, TBD.

Test plan for issue:

  • Unit tests have been added for the regular expressions themselves (against "fake" install logs), as well as for the generator's conversion logic.
  • The generated additional-install-log-regexes ConfigMap has been tested in a Hive cluster and ARO cluster creations have been performed that reproduce the scenarios within this PR, and validate that Hive has propagated the expected Reasons.

Is there any documentation that needs to be updated for this PR?

No.

@tsatam tsatam force-pushed the ARO-3220/hive-install-log-regexes branch from f9c8a96 to 684b248 Compare August 15, 2023 19:08
@tsatam
Copy link
Collaborator Author

tsatam commented Aug 29, 2023

Changes included in #3116

@tsatam tsatam closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant