Enable preconfigured NSG flag on azure-cli

[gouthamMN]

Which issue this PR addresses:

Fixes:
https://issues.redhat.com/browse/ARO-2591
https://issues.redhat.com/browse/ARO-2589
https://issues.redhat.com/browse/ARO-4016

What this PR does / why we need it:

1. Bumps api version used and adds parameter --enable-preconfigured-nsg to az aro cli extension for using preconfigured NSGs. Allowed values for the flag are true or false and by default, preconfigured NSG will be disabled.
2. Adds network contributor role to BYO-NSGs when preconfigured NSG feature is enabled.
3. Update az cli to include subnets from workerProfilesStatus field when available.

This should probably not be merged until the next stable API is released.

Test plan for issue:

Updated/added unit tests and existing E2E tests.

Is there any documentation that needs to be updated for this PR?

Yes, the Azure Doc will need to be updated though that will be a separate effort.

[petrkotas]

Hi @gouthamMN good work. LGTM. I think we can merge as 1) the API should be already released, 2) this will affect only extension which we use for development. The same work will need to be backported to upstream: https://github.com/Azure/azure-cli to make it available to the public.

[gouthamMN]

Hi @gouthamMN good work. LGTM. I think we can merge as 1) the API should be already released, 2) this will affect only extension which we use for development. The same work will need to be backported to upstream: https://github.com/Azure/azure-cli to make it available to the public.

ARM manifest rollout and upstreaming azure-rest-api-specs swagger is still in progress.

[SudoBrendan]

ARM manifest rollout and upstreaming azure-rest-api-specs swagger is still in progress.

I'd agree with Petr. We should be safe to merge into this repo's /python directory, since ARO engineering should be the only ones using this code. We have historically merged here early (because we can use localhost RP instances to test), then upstreamed changes once REST Specs and ARM Manifest Rollout are complete. This process is super unintuitive, so I drew up some diagrams about it recently.

[SudoBrendan]

This is nearly there, I left a few grammar nits and one question. I think it would be good to check with the BU on all the error messaging before we merge.

[gouthamMN]

ARM manifest rollout and upstreaming azure-rest-api-specs swagger is still in progress.

I'd agree with Petr. We should be safe to merge into this repo's /python directory, since ARO engineering should be the only ones using this code. We have historically merged here early (because we can use localhost RP instances to test), then upstreamed changes once REST Specs and ARM Manifest Rollout are complete. This process is super unintuitive, so I drew up some diagrams about it recently.

@SudoBrendan I'm fine merging the changes. Thank you for updating that wiki.