increase machine health check node unready timeout to 15m #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-amann
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
bennerv
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
lgtm
The 15m change is due to customers having issues during upgrade where nodes would be NotReady while they are rebooting and running rpm-ostree commands to upgrade to the latest RHCOS versions.
MHC was killing worker nodes causing some disruption during upgrades. This should prevent that. It will "negatively" impact the removal of NotReady nodes in a sense they will take longer to replace.
We should confirm the Node Not Ready monitor shouldn't fire within this 15m timeframe, but a bit after (30m or so).
cadenmarchese
approved these changes
Aug 31, 2023
s-amann
added
ready-for-review
next-release
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SrinivasAtmakuri
pushed a commit
to SrinivasAtmakuri/ARO-RP
that referenced
this pull request
Sep 18, 2023
* increase machine health check node unready timeout to 15m * update mhc docs * increase machine health check node startup timeout to 25m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-4040
What this PR does / why we need it:
Test plan for issue:
Is there any documentation that needs to be updated for this PR?