-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping up MUO to v0.1.952 #3149
Conversation
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question - otherwise lgtm
@@ -89,7 +89,7 @@ func MdsdImage(acrDomain string) string { | |||
|
|||
// MUOImage contains the location of the Managed Upgrade Operator container image | |||
func MUOImage(acrDomain string) string { | |||
return acrDomain + "/managed-upgrade-operator:aro-b4" | |||
return acrDomain + "/app-sre/managed-upgrade-operator:v0.1.952-44b631a" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did the /app-sre/
change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the upstream image builds in quay are under that path, and our mirror code is later replicating it into ACR.
On the other hand, the previous aro-b4 image was a custom ARO build (needed for FIPS support at that time), which was specifically pushed to ACR, and not published under /app-sre repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Amber Brown <[email protected]>
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-4088
This PR follows PR #3147
What this PR does / why we need it:
Bump up MUO image to include recent bugfixes
Test plan for issue:
NOTE E2E tests for the PR have passed (see here), however the pipeline was cancelled by Azure during cleanup phase.
Smoke test run manually:
Is there any documentation that needs to be updated for this PR?
A separate Epic ARO-2732 will document MUO lifecycle in ARO.