Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping up MUO to v0.1.952 #3149

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Bumping up MUO to v0.1.952 #3149

merged 4 commits into from
Sep 12, 2023

Conversation

tiguelu
Copy link
Contributor

@tiguelu tiguelu commented Sep 6, 2023

Which issue this PR addresses:

https://issues.redhat.com/browse/ARO-4088
This PR follows PR #3147

What this PR does / why we need it:

Bump up MUO image to include recent bugfixes

Test plan for issue:

NOTE E2E tests for the PR have passed (see here), however the pipeline was cancelled by Azure during cleanup phase.

Smoke test run manually:

  • Create new 4.11.44 cluster (no upgrade history), which runs aro-b4 MUO image
  • Create UpgradeConfig aiming for 4.12.25 and confirm MUO pods CrashLoopBackoff
  • Upgrade MUO to v0.1.952 and confirm pods get into Running and upgrade starts
  • Wait for Upgrade completion and check pods are Running and history shows in UpgradeConfig
  • Create UpgradeConfig aiming for 4.13.9 and confirm MUO pods don't fail and upgrade starts (cluster with upgrade history)
  • Wait for Upgrade completion and check pods are still Running and history shows in UpgradeConfig

Is there any documentation that needs to be updated for this PR?

A separate Epic ARO-2732 will document MUO lifecycle in ARO.

@bennerv
Copy link
Collaborator

bennerv commented Sep 11, 2023

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@bennerv bennerv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question - otherwise lgtm

@@ -89,7 +89,7 @@ func MdsdImage(acrDomain string) string {

// MUOImage contains the location of the Managed Upgrade Operator container image
func MUOImage(acrDomain string) string {
return acrDomain + "/managed-upgrade-operator:aro-b4"
return acrDomain + "/app-sre/managed-upgrade-operator:v0.1.952-44b631a"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did the /app-sre/ change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the upstream image builds in quay are under that path, and our mirror code is later replicating it into ACR.

On the other hand, the previous aro-b4 image was a custom ARO build (needed for FIPS support at that time), which was specifically pushed to ACR, and not published under /app-sre repo.

Copy link
Collaborator

@cadenmarchese cadenmarchese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! LGTM

Copy link
Member

@petrkotas petrkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petrkotas petrkotas merged commit b1db194 into Azure:master Sep 12, 2023
17 of 18 checks passed
@tiguelu tiguelu deleted the muo-bumpup branch September 12, 2023 12:58
SrinivasAtmakuri pushed a commit to SrinivasAtmakuri/ARO-RP that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next-release To be included in the next RP release rollout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants