Refactor /test/util/applens package names/directories #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SudoBrendan
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
SudoBrendan
changed the title
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
e2e failure unrelated to change made. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-4264 (partial)
What this PR does / why we need it:
This is an initial refactor to make subsequent changes that allow tests to mock HTTP client calls via mocking httpTransport. This refactor changes the name of this package to reflect its directory name, and also allows us to extend the changes to have a
test/util/http/clientlibrary alongside it.Test plan for issue:
Current build and tests should pass to prove this rename works. This is only a refactor of current test related code.
Is there any documentation that needs to be updated for this PR?
N/A