e2e: Spew ODataError details before panicing #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnes
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
mbarnes
force-pushed
the
e2e-msgraph-errors
branch
from
a2394f3
to
c9124c4
Compare
mbarnes
added
good first issue
s-amann
approved these changes
Nov 7, 2023
bennerv
approved these changes
Nov 7, 2023
SudoBrendan
approved these changes
Nov 8, 2023
|
Hah - so, if E2E fails and showcases the new functionality, is that ❌ actually a ✔️ ? 😂 |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mbarnes
force-pushed
the
e2e-msgraph-errors
branch
from
c9124c4
to
17a3daf
Compare
|
Rebased on master after #3269 merged, which will hopefully fix E2E. |
bennerv
approved these changes
Nov 9, 2023
ventifus
pushed a commit
to ventifus/ARO-RP
that referenced
this pull request
Feb 7, 2024
Co-authored-by: Matthew Barnes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Errors returned from MS Graph APIs are useless as an
errortype. They just use a hard-coded message:To get to the real information requires casting the
erroras anODataErrorand unpacking the details, which I usually just "spew" to a log.This is to help debug such errors we're currently seeing in E2E tests.