Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintenance state for customer action needed #3294

Merged
merged 66 commits into from
Jan 10, 2024

Conversation

niontive
Copy link
Collaborator

@niontive niontive commented Nov 29, 2023

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-4365

What this PR does / why we need it:

If a maintenance operation fails, we may need the customer to take action. We will notify the customer via a resource health check signal.

This PR implements a new signal to tell the customer to take action. This PR implements arrows 11, 12 and 13 in this diagram.

Test plan for issue:

  • Unit tests
  • Test in INT

Is there any documentation that needs to be updated for this PR?

See above diagram link

Copy link

@bbethell-1 bbethell-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niontive
Copy link
Collaborator Author

Code Review December 13th:

  • Verify if we need code to reject transition from customer action needed to maintenance ongoing. This prevents us from accidentally from running maintenance on a cluster that has failed + needs customer action

@niontive
Copy link
Collaborator Author

Reviewed with @bennerv and @SudoBrendan. We'll not support blocking transition from "customer action needed" to "maintenance ongoing." No code changes needed - code as is supports this.

Copy link
Collaborator

@bennerv bennerv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bennerv bennerv added next-release To be included in the next RP release rollout ready-for-review labels Jan 6, 2024
@lranjbar
Copy link
Contributor

lranjbar commented Jan 8, 2024

LGTM

@cadenmarchese
Copy link
Collaborator

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cadenmarchese cadenmarchese merged commit 477a045 into Azure:master Jan 10, 2024
18 checks passed
LiniSusan pushed a commit to LiniSusan/ARO-RP that referenced this pull request Jan 25, 2024
ventifus pushed a commit to ventifus/ARO-RP that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release To be included in the next RP release rollout ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants